Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add isTokenGovernanceCompatible function #269

Merged
merged 25 commits into from
Aug 17, 2023
Merged

Feature: Add isTokenGovernanceCompatible function #269

merged 25 commits into from
Aug 17, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Aug 14, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-639

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

heueristik
heueristik suggested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isTokenGovernanceCompatible function does not match with the TokenVotingSetup code. Please change this

heueristik
heueristik suggested changes Aug 16, 2023
View reviewed changes
modules/client/CHANGELOG.md Outdated Show resolved Hide resolved
modules/client/examples/03-tokenVoting-client/20-is-governance-token-compatible.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/types.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/utils.ts Show resolved Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts Outdated Show resolved Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts Outdated Show resolved Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts Outdated Show resolved Hide resolved
modules/common/src/errors.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/client/methods.ts Outdated Show resolved Hide resolved
@josemarinas josemarinas force-pushed the f/OS-639-add-governance-token-check branch from 2c31b62 to ada2f9d Compare August 17, 2023 07:48
heueristik
heueristik previously approved these changes Aug 17, 2023
View reviewed changes
Rekard0
Rekard0 reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need empty line at the end of multiple files, can u check them please

@josemarinas josemarinas force-pushed the f/OS-639-add-governance-token-check branch from e8ff936 to bd97f4b Compare August 17, 2023 09:26
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM common-release Publishes the current version of common subpackage on NPM client-common-release Releases a new version of the client-common package labels Aug 17, 2023
Rekard0
Rekard0 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josemarinas josemarinas merged commit 4cb651c into develop Aug 17, 2023
7 checks passed
@josemarinas josemarinas deleted the f/OS-639-add-governance-token-check branch August 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@heueristik heueristik heueristik approved these changes

@mathewmeconry mathewmeconry mathewmeconry left review comments

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM common-release Publishes the current version of common subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @mathewmeconry @Rekard0 @heueristik