-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add isTokenGovernanceCompatible function #269
Conversation
modules/client/examples/03-tokenVoting-client/20-is-governance-token-compatible.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The isTokenGovernanceCompatible
function does not match with the TokenVotingSetup
code. Please change this
modules/client/examples/03-tokenVoting-client/20-is-governance-token-compatible.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
2c31b62
to
ada2f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need empty line at the end of multiple files, can u check them please
modules/client/test/integration/tokenVoting-client/methods.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Heuer <[email protected]>
…-token-compatible.ts Co-authored-by: Michael Heuer <[email protected]>
Co-authored-by: Michael Heuer <[email protected]>
Co-authored-by: Michael Heuer <[email protected]>
…t.ts Co-authored-by: Michael Heuer <[email protected]>
bd97f4b
e8ff936
to
bd97f4b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task ID: OS-639
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the[UPCOMING]
title and before the latest version.