-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add isDaoUpdateProposal #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versioning seems to me now a complete mess... If the SDK is complete for the upgrade you can remove the -rc
stuff from my point of view because this will be the release and thus no candidate anymore.
If this isn't the final release for the upgrade I suggest you update the -rc
part and not the semver because it is still a candidate and couldn't be final
7b9c1fe
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task ID: OS-696
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the[UPCOMING]
title and before the latest version.