Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add isDaoUpdateProposal #283

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Feature: Add isDaoUpdateProposal #283

merged 5 commits into from
Oct 5, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Oct 3, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-696

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

Rekard0
Rekard0 previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mathewmeconry
mathewmeconry previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versioning seems to me now a complete mess... If the SDK is complete for the upgrade you can remove the -rc stuff from my point of view because this will be the release and thus no candidate anymore.
If this isn't the final release for the upgrade I suggest you update the -rc part and not the semver because it is still a candidate and couldn't be final

@josemarinas josemarinas dismissed stale reviews from mathewmeconry and Rekard0 via 7b9c1fe October 5, 2023 09:54
@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM common-release Publishes the current version of common subpackage on NPM client-common-release Releases a new version of the client-common package labels Oct 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
16.0% 16.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@josemarinas josemarinas merged commit 878910a into develop Oct 5, 2023
7 of 8 checks passed
@josemarinas josemarinas deleted the f/OS-696-dao-update-checks branch October 5, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry left review comments

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM common-release Publishes the current version of common subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @mathewmeconry @Rekard0