Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: isMember function for tokenVoting plugin #310

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix: isMember function for tokenVoting plugin #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19943e2
reversed the tokenVoting isMember query id order
sepehr2github Nov 29, 2023
e1dd26e
add the change to tokenVoting function insteadOf multisig
sepehr2github Dec 1, 2023
77be61f
remove yarn lock changes
sepehr2github Dec 1, 2023
4bed9e1
add yarn lock eof
sepehr2github Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ TEMPLATE:
### Fixed

- Added missing security check that checks that the `to` address in the permission actions is the DAO address
- Fix isMember function for tokenVoting DAOs by reversing the query id order

## [1.19.2]

Expand Down
2 changes: 1 addition & 1 deletion modules/client/src/tokenVoting/internal/client/methods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ export class TokenVotingClientMethods extends ClientCore
query,
params: {
id:
`${params.pluginAddress.toLowerCase()}_${params.address.toLowerCase()}`,
`${params.address.toLowerCase()}_${params.pluginAddress.toLowerCase()}`,
blockHeight: params.blockNumber ? { number: params.blockNumber } : null,
},
name,
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15955,3 +15955,4 @@ yup@^1.2.0:
tiny-case "^1.0.3"
toposort "^2.0.2"
type-fest "^2.19.0"

Loading