Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make metadataHash optional in proposal alnd DAO types #335

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/client-common/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ TEMPLATE:

## [UPCOMING]

- Make `metadataHash` optional in proposal and dao objects.

## [1.15.2]

- Added `metadataHash` field to proposal and dao objects.

## [1.15.0]
Expand Down
2 changes: 1 addition & 1 deletion modules/client-common/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@aragon/sdk-client-common",
"author": "Aragon Association",
"version": "1.15.2",
"version": "1.15.3",
"license": "MIT",
"main": "dist/index.js",
"module": "dist/sdk-client-common.esm.js",
Expand Down
4 changes: 2 additions & 2 deletions modules/client-common/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export type ProposalBase = {
};
creatorAddress: string;
metadata: ProposalMetadata;
metadataHash: string;
metadataHash?: string;
startDate: Date;
endDate: Date;
creationDate: Date;
Expand All @@ -220,7 +220,7 @@ export type ProposalListItemBase = {
};
creatorAddress: string;
metadata: ProposalMetadataSummary;
metadataHash: string;
metadataHash?: string;
startDate: Date;
endDate: Date;
status: ProposalStatus;
Expand Down
4 changes: 4 additions & 0 deletions modules/client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ TEMPLATE:

## [UPCOMING]

- Make `metadataHash` optional in proposal and dao objects.

## [1.23.4]

- Added `metadataHash` field to proposal and dao objects.

## [1.23.2]
Expand Down
4 changes: 2 additions & 2 deletions modules/client/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@aragon/sdk-client",
"author": "Aragon Association",
"version": "1.23.4",
"version": "1.23.5",
"license": "MIT",
"main": "dist/index.js",
"module": "dist/sdk-client.esm.js",
Expand Down Expand Up @@ -69,7 +69,7 @@
"dependencies": {
"@aragon/osx-commons-configs": "^0.4.0",
"@aragon/osx-ethers": "1.3.0",
"@aragon/sdk-client-common": "^1.15.2",
"@aragon/sdk-client-common": "^1.15.3",
"@aragon/sdk-ipfs": "^1.1.0",
"@ethersproject/abstract-signer": "^5.5.0",
"@ethersproject/bignumber": "^5.6.0",
Expand Down
4 changes: 2 additions & 2 deletions modules/client/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export type DaoDetails = {
address: string;
ensDomain: string;
metadata: DaoMetadata;
metadataHash: string;
metadataHash?: string;
creationDate: Date;
plugins: InstalledPluginListItem[];
};
Expand All @@ -49,7 +49,7 @@ export type DaoListItem = {
description: string;
avatar?: string;
};
metadataHash: string;
metadataHash?: string;
plugins: InstalledPluginListItem[];
};

Expand Down
Loading