Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update configs dependencies #336

Merged
merged 2 commits into from
May 21, 2024
Merged

chore: update configs dependencies #336

merged 2 commits into from
May 21, 2024

Conversation

josemarinas
Copy link
Contributor

Description

Add support for zkSync sepolia

Task ID: OS-XXX

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM client-common-release Releases a new version of the client-common package labels May 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@josemarinas josemarinas merged commit b5920b3 into develop May 21, 2024
7 of 8 checks passed
@josemarinas josemarinas deleted the f/add-support-for-zkSync-sepolia branch May 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @Rekard0