Internal audit improvements

tests/asymmetric.test.ts

@@ -67,10 +67,23 @@ describe("Symmetric encryption", () => {
     const ciphertext1 = encrypt(bytes, bob.publicKey);
     const ciphertext2 = encrypt("Hello world", bob.publicKey);
 
+    // ok
     expect(() => decryptBytes(ciphertext1, bob)).not.toThrow();
     expect(() => decryptString(ciphertext2, bob)).not.toThrow();
 
-    expect(() => decryptBytes(ciphertext1, cindy)).toThrow();
-    expect(() => decryptString(ciphertext2, cindy)).toThrow();
+    // ko
+    try {
+      decryptBytes(ciphertext1, cindy);
+      throw new Error("Should have thrown but didn't");
+    } catch (err: any) {
+      expect(err.message).toBe("incorrect key pair for the given ciphertext");
+    }
+
+    try {
+      decryptString(ciphertext2, cindy);
+      throw new Error("Should have thrown but didn't");
+    } catch (err: any) {
+      expect(err.message).toBe("incorrect key pair for the given ciphertext");
+    }
   });
 });

tests/proposal-encryption.test.ts

@@ -96,9 +96,12 @@ describe("Proposal data encryption", () => {
     }).not.toThrow();
 
     for (const otherKey of otherKeys) {
-      expect(() => {
+      try {
         decryptProposal(data, otherKey);
-      }).toThrow();
+        throw new Error("Should have thrown but didn't");
+      } catch (err: any) {
+        expect(err.message).toBe("wrong secret key for the given ciphertext");
+      }
     }
   });
 });
@@ -150,9 +153,12 @@ describe("Symmetric key encryption across members", () => {
     );
 
     for (let i = 0; i < encryptedItems.length; i++) {
-      expect(() => {
+      try {
         decryptSymmetricKey(encryptedItems, intruders[i]);
-      }).toThrow();
+        throw new Error("Should have thrown but didn't");
+      } catch (err: any) {
+        expect(err.message).toBe("The given keypair cannot decrypt any of the ciphertext's");
+      }
     }
 
     for (let i = 0; i < encryptedItems.length; i++) {

tests/symmetric.test.ts

@@ -51,7 +51,18 @@ describe("Symmetric encryption", () => {
     expect(() => decryptBytes(encryptedPayload1, symKey)).not.toThrow();
     expect(() => decryptString(encryptedPayload2, symKey)).not.toThrow();
 
-    expect(() => decryptBytes(encryptedPayload1, wrongKey)).toThrow();
-    expect(() => decryptString(encryptedPayload2, wrongKey)).toThrow();
+    try {
+      decryptBytes(encryptedPayload1, wrongKey);
+      throw new Error("Should have thrown but didn't");
+    } catch (err: any) {
+      expect(err.message).toBe("wrong secret key for the given ciphertext");
+    }
+
+    try {
+      decryptString(encryptedPayload2, wrongKey);
+      throw new Error("Should have thrown but didn't");
+    } catch (err: any) {
+      expect(err.message).toBe("wrong secret key for the given ciphertext");
+    }
   });
 });