Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-wait.shを実装した #96

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

yuiseki
Copy link
Member

@yuiseki yuiseki commented Apr 18, 2020

jobに溜まってた(回答されず放置されていた)ものを探し出してqueueに戻す処理書きました

@yuiseki yuiseki self-assigned this Apr 18, 2020
@yuiseki yuiseki requested review from kobake and takano32 April 18, 2020 08:43
Copy link
Collaborator

@tamakiii tamakiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO resultに存在しないかチェックしておく ができればよさそうな気がします〜

@@ -0,0 +1,23 @@
now_ts=`date '+%s'`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#!/bin/bash ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#!/usr/bin/env bash の方がよいかも

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本、 Linux で bash のときは env 使わないのがいいです。
語ると長くなります。


keys=`redis-cli KEYS "vscovid-crawler:job-*"`
for key in $keys; do
job=`redis-cli GET $key`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab~~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このプロジェクトはハードタブ、という割り切りも必要なんでは。

@yuiseki yuiseki marked this pull request as draft April 18, 2020 09:59
@515hikaru
Copy link
Collaborator

  • インデントをスペース4に統一したい
  • shebang を #!/usr/bin/env bash に統一したい
  • そういうポリシーをどこかに書きたい

という会話をした。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants