Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitLab by @JulietteOrtholand on Oct 25, 2024, 16:54
What does the code in the MR do ?
As explain in the slide below (the whole course is available at the end of the MR), the sources in an ICA cannot be gaussian... An for now in leaspy they are....
undefined
The idea was to replace the gaussian distribution by an other one. I first though about log-normal distribution, which is according to Stéphanie Allassonière paper (in ref at the end of the MR) "probably one of the most commonly used parametric models for ICA. One reason for this is that the logistic probability density function (p.d.f.) is easy to describe, smooth, with a shape similar to the Gaussian, but with heavier, exponential, tails.". But it is not eay to center it on 0 ... So I finally used a Laplace distribution.
Where should the reviewer start ?
There are a few lines changed, and the code run. But still no scientific tests have been done. Thus, for now the main questions are:
References
undefined
undefined