Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the source distribution #297

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

NicolasGensollen
Copy link
Member

In GitLab by @JulietteOrtholand on Oct 25, 2024, 16:54

What does the code in the MR do ?

As explain in the slide below (the whole course is available at the end of the MR), the sources in an ICA cannot be gaussian... An for now in leaspy they are....
undefined

The idea was to replace the gaussian distribution by an other one. I first though about log-normal distribution, which is according to Stéphanie Allassonière paper (in ref at the end of the MR) "probably one of the most commonly used parametric models for ICA. One reason for this is that the logistic probability density function (p.d.f.) is easy to describe, smooth, with a shape similar to the Gaussian, but with heavier, exponential, tails.". But it is not eay to center it on 0 ... So I finally used a Laplace distribution.

Where should the reviewer start ?

There are a few lines changed, and the code run. But still no scientific tests have been done. Thus, for now the main questions are:

  • does the model still works: can it find back the model parameters (apart from the mixing matrix) and the random parameters,
  • is now A identifiable?

References

undefined

undefined

@NicolasGensollen
Copy link
Member Author

In GitLab by @JulietteOrtholand on Oct 25, 2024, 16:54

requested review from @sofia.kaisaridi

@NicolasGensollen
Copy link
Member Author

In GitLab by @JulietteOrtholand on Oct 25, 2024, 16:55

changed target branch from master to v2

@NicolasGensollen
Copy link
Member Author

In GitLab by @JulietteOrtholand on Feb 7, 2025, 17:59

This MR need to be tested, before going further. @sofia.kaisaridi are you still interested? Do you plan to test it? Or should I close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant