Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go version to 1.20 #716

Merged
merged 11 commits into from
Jul 20, 2023
Merged

feat: upgrade go version to 1.20 #716

merged 11 commits into from
Jul 20, 2023

Conversation

dobet
Copy link
Contributor

@dobet dobet commented Jul 14, 2023

What this PR does:
upgrade go version from 1.18 to 1.20
Which issue(s) this PR fixes:

Fixes #715

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dongzl dongzl added the CI/CD CI/CD label Jul 17, 2023
@dongzl dongzl added this to the 0.2.0 milestone Jul 17, 2023
@dongzl
Copy link
Contributor

dongzl commented Jul 17, 2023

please fix the README

@jjeffcaii
Copy link
Contributor

Please upgrade the golangci-lint version in the Github action files and pre-commit configuration files.

@dobet
Copy link
Contributor Author

dobet commented Jul 17, 2023

Place update .github/workflows/*.yaml go version, or how to use my commit *.yaml to run action?

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch coverage: 57.14% and no project coverage change.

Comparison is base (a57148e) 37.28% compared to head (8072a1e) 37.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   37.28%   37.28%           
=======================================
  Files         230      230           
  Lines       24460    24460           
=======================================
  Hits         9120     9120           
  Misses      14296    14296           
  Partials     1044     1044           
Impacted Files Coverage Δ
pkg/config/misc.go 0.00% <0.00%> (ø)
pkg/mysql/client.go 30.70% <0.00%> (ø)
pkg/mysql/utils.go 11.87% <0.00%> (ø)
pkg/runtime/calc/logic/logic.go 51.03% <ø> (ø)
pkg/runtime/function/cast_char.go 46.04% <100.00%> (ø)
pkg/selector/weight_random.go 77.41% <100.00%> (ø)
pkg/util/bytefmt/bytefmt.go 77.04% <100.00%> (ø)
pkg/util/charsetconv/charsetconv.go 50.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dobet dobet requested a review from Mulavar July 17, 2023 16:59
@jjeffcaii jjeffcaii changed the title [feat] upgrade go version to 1.20 feat: upgrade go version to 1.20 Jul 18, 2023
@dobet dobet requested a review from AlexStocks July 19, 2023 03:36
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dongzl dongzl merged commit 0457c45 into arana-db:master Jul 20, 2023
12 checks passed
Lvnszn pushed a commit to Lvnszn/arana that referenced this pull request Jul 22, 2023
* [feat] upgrade go version to 1.20

* update Readme

* update golangci-lint version to 1.53.3

* update github action yaml

* update version str

* update ioutil and rand pkg

* update math/rand.Read to crypto/rand.Read

* update fmt error

* update crypto/rand.Read

* fmt logging.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Go version to 1.20 for arana.
7 participants