Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-741 | Options API [3.12] #317

Merged
merged 10 commits into from
Apr 24, 2024
Merged

DE-741 | Options API [3.12] #317

merged 10 commits into from
Apr 24, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Jan 17, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (99f5d9b) 98.45% compared to head (7b8dbf5) 98.12%.

❗ Current head 7b8dbf5 differs from pull request most recent head 85e1266. Consider uploading reports for the commit 85e1266 to get more accurate results

Files Patch % Lines
arango/database.py 12.50% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   98.45%   98.12%   -0.34%     
==========================================
  Files          26       26              
  Lines        4136     4154      +18     
==========================================
+ Hits         4072     4076       +4     
- Misses         64       78      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aMahanna aMahanna changed the title wip: DE-741 | Options API wip: DE-741 | Options API [3.12] Jan 17, 2024
@aMahanna aMahanna marked this pull request as draft January 17, 2024 21:01
@aMahanna aMahanna changed the title wip: DE-741 | Options API [3.12] DE-741 | Options API [3.12] Apr 22, 2024
@aMahanna aMahanna marked this pull request as ready for review April 22, 2024 21:04
Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit f4071f2 into main Apr 24, 2024
19 of 36 checks passed
@aMahanna aMahanna deleted the DE-741 branch April 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants