Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature upload via url #231

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Feature upload via url #231

merged 13 commits into from
Dec 22, 2023

Conversation

sanglevinh
Copy link
Collaborator

No description provided.

@sanglevinh sanglevinh linked an issue Dec 8, 2023 that may be closed by this pull request
[103] URLリンクからのデータアップロード #173
Closed
1 task
@ReiHashimoto
Copy link

ReiHashimoto commented Dec 15, 2023 •
edited by sanglevinh
Loading

@sanglevinh
In addition to the review, please fix following problem.

After uploading file via url, csv data cannot be previewed on clicking settings button.
Screenshot 2023-12-15 at 17 11 39

@sanglevinh sanglevinh force-pushed the feature/up_load_url_link branch from cefe24f to 89816b8 Compare December 18, 2023 03:55
@sanglevinh sanglevinh force-pushed the feature/up_load_url_link branch from 481c2e5 to 6129f67 Compare December 18, 2023 08:36
@sanglevinh
Copy link
Collaborator Author

@sanglevinh In addition to the review, please fix following problem.

After uploading file via url, csv data cannot be previewed on clicking settings button. Screenshot 2023-12-15 at 17 11 39

i fixed it, pls check it again

@sanglevinh sanglevinh marked this pull request as ready for review December 18, 2023 09:10
@ReiHashimoto
Copy link

ReiHashimoto commented Dec 21, 2023 •
edited
Loading

@sanglevinh

After uploading file via url, csv data cannot be previewed on clicking settings button.

related to this, uploaded file is not in Select File list.
calling /files api would be required after download completed.
Screenshot 2023-12-21 at 17 55 51

@sanglevinh
Copy link
Collaborator Author

@sanglevinh

After uploading file via url, csv data cannot be previewed on clicking settings button.

related to this, uploaded file is not in Select File list. calling /files api would be required after download completed. Screenshot 2023-12-21 at 17 55 51

@ReiHashimoto i fixed it, pls check it again

@ReiHashimoto ReiHashimoto merged commit a8c284f into develop-main Dec 22, 2023
2 checks passed
@ReiHashimoto ReiHashimoto deleted the feature/up_load_url_link branch December 22, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReiHashimoto ReiHashimoto ReiHashimoto approved these changes

@itutu-tienday itutu-tienday Awaiting requested review from itutu-tienday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[103] URLリンクからのデータアップロード
2 participants
@sanglevinh @ReiHashimoto