Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roi_fluo_from_hdf5 Adding Tranpose Parameter #596

Merged

Conversation

tsuchiyama-araya
Copy link
Collaborator

内容

他のWorkflowデータからのroi_fluo_from_hdf5のFluorescenceのデータが反転しているため、
Tranposeするかをパラメーターに変更して、必要な時だけにTranposeするようにします。

@milesAraya
Copy link
Collaborator

このブランチにこの質問について、対応出来ます?それか、違うのブランチの方がよろしいでしょうか
#575 (comment)

@tsuchiyama-araya
Copy link
Collaborator Author

tsuchiyama-araya commented Feb 11, 2025

@milesAraya

このブランチにこの質問について、対応出来ます?それか、違うのブランチの方がよろしいでしょうか #575 (comment)

気づきませんでした。
ありがとうございます。

Could you make it so users don't need to have fluo & roi, but one or the other is also okay? At the moment, if fluo and roi are not connected, there is an error

Do you think we need to add this? Because if they just want to use roi they can use roi_from_hdf5. The same with fluo data.

@milesAraya
Copy link
Collaborator

milesAraya commented Feb 12, 2025

Do you think we need to add this? Because if they just want to use roi they can use roi_from_hdf5. The same with fluo data

I think the idea would be to delete the roi_from_hdf5 and fluo_from_hdf5 nodes, and just have a single node that can do all of these things, no? I guess we should check with matsumoto-san

@tsuchiyama-araya
Copy link
Collaborator Author

Do you think we need to add this? Because if they just want to use roi they can use roi_from_hdf5. The same with fluo data

I think the idea would be to delete the roi_from_hdf5 and fluo_from_hdf5 nodes, and just have a single node that can do all of these things, no? I guess we should check with matsumoto-san

@milesAraya
After checking with Matsumoto-san for the meantime we are planning on not deleting roi_from_hdf5 and fluo_from_hdf5. Therefor, the validation i will be implementing is to have roi data and fluo data together.

@tsuchiyama-araya
Copy link
Collaborator Author

There is no output for this node. Could you add output? Same as fluo_from_hdf5, roi_from_hdf5?

Currently there is no need for this based on what they are asking for us.
As long as they want the roi data and fluo data together.

@tsuchiyama-araya
Copy link
Collaborator Author

ログについての実装ですが、Snackbarのエラー表示はWorkflowが失敗する時に発生しています。
今回のエラーは、Node内でのエラーなので、今までの仕様で大丈夫かと思いっています。

@milesAraya
現状の仕様を一旦リリースして、もしUserから入力すべき値がわからないことが多かったら、Algoの使い方をDocsで追加した方が
良いのかと思いました。

Screenshot 2025-02-17 at 8 39 56

@tsuchiyama-araya tsuchiyama-araya merged commit bb6b209 into develop-main Feb 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roi_fluo_from_hdf5 output is transposed when using with suite2p workflows data
3 participants