Use RootObject to improve validation (#175)

arcalot · Apr 23, 2024 · 97f5031 · 97f5031
1 parent 5c54a86
commit 97f5031
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/go.mod b/go.mod
@@ -13,7 +13,7 @@ require (
 	go.flow.arcalot.io/dockerdeployer v0.6.1
 	go.flow.arcalot.io/expressions v0.4.1
 	go.flow.arcalot.io/kubernetesdeployer v0.9.1
-	go.flow.arcalot.io/pluginsdk v0.10.0-beta1
+	go.flow.arcalot.io/pluginsdk v0.11.1
 	go.flow.arcalot.io/podmandeployer v0.9.0
 	go.flow.arcalot.io/pythondeployer v0.6.0
 	go.flow.arcalot.io/testdeployer v0.6.0

diff --git a/go.sum b/go.sum
@@ -143,8 +143,8 @@ go.flow.arcalot.io/expressions v0.4.1 h1:WOl3DtDcWAmPKupwYxJV3bVYKPoMgAmQbECfiUg
 go.flow.arcalot.io/expressions v0.4.1/go.mod h1:FA/50wX1+0iTgW/dFeeE1yOslZSmfBaMNR4IiMYRwxc=
 go.flow.arcalot.io/kubernetesdeployer v0.9.1 h1:AGnJFazehAENXxGMCF0Uc7aG9F0LpvuhoyQFu8deJG0=
 go.flow.arcalot.io/kubernetesdeployer v0.9.1/go.mod h1:yvxT3VwmyrlIi4422pxl02z4QeU2Gvbjg5aQB17Ye4s=
-go.flow.arcalot.io/pluginsdk v0.10.0-beta1 h1:VGhGIJTZiAfb9J9NZGgMPFO4wb2i94PEiZ2e+ZkNz4A=
-go.flow.arcalot.io/pluginsdk v0.10.0-beta1/go.mod h1:7HafTRTFTYRbJ4sS/Vn0CFrHlaBpEoyOX4oNf612XJM=
+go.flow.arcalot.io/pluginsdk v0.11.1 h1:vutbhJVSqCqVvgYHNTEYa0Hx0p+lxh9HoyFhhC+ui94=
+go.flow.arcalot.io/pluginsdk v0.11.1/go.mod h1:7HafTRTFTYRbJ4sS/Vn0CFrHlaBpEoyOX4oNf612XJM=
 go.flow.arcalot.io/podmandeployer v0.9.0 h1:BSN/s8BeEUIIqOQm6/I5LOzAUzYFrVO1/3p1hcbWD4g=
 go.flow.arcalot.io/podmandeployer v0.9.0/go.mod h1:FWwelCoH0jfQEYQAJ5mzLElZIXlRfyLP4osjcuQ6n30=
 go.flow.arcalot.io/pythondeployer v0.6.0 h1:ptAurEJ2u2U127nK6Kk7zTelbkk6ipPqZcwnTmqB9vo=

diff --git a/workflow/executor.go b/workflow/executor.go
@@ -383,7 +383,7 @@ func addScopesWithReferences(allNamespaces map[string]schema.Scope, scope schema
 	// First, just adds the scope
 	allNamespaces[prefix] = scope
 	// Next, checks all properties for resolved references that reference objects outside of this scope.
-	rootObject := scope.Objects()[scope.Root()]
+	rootObject := scope.RootObject()
 	for propertyID, property := range rootObject.Properties() {
 		if property.Type().TypeID() == schema.TypeIDRef {
 			refProperty := property.Type().(schema.Ref)

diff --git a/workflow/workflow_test.go b/workflow/workflow_test.go
@@ -284,7 +284,7 @@ func TestWithDoubleSerializationDetection(t *testing.T) {
 	)
 	// First, get the root object
 	inputSchema := preparedWorkflow.Input()
-	rootObject := inputSchema.Objects()[inputSchema.Root()]
+	rootObject := inputSchema.RootObject()
 	type testIterType struct {
 		defaultSpec *string
 		input       map[string]any