Only report error when error is present

arcalot · Nov 9, 2023 · c93ccc6 · c93ccc6
1 parent 85636b4
commit c93ccc6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/internal/step/plugin/provider.go b/internal/step/plugin/provider.go
@@ -270,8 +270,13 @@ func (p *pluginProvider) LoadSchema(inputs map[string]any, _ map[string][]byte)
 		cancel()
 		// Close it. This allows it go get the error messages.
 		deployerErr := pluginConnector.Close()
-		return nil, fmt.Errorf("failed to read plugin schema from '%s' (%w). Deployer close error: (%s)",
-			pluginSource, err, deployerErr.Error())
+		if deployerErr == nil {
+			return nil, fmt.Errorf("failed to read plugin schema from '%s' (%w)",
+				pluginSource, err)
+		} else {
+			return nil, fmt.Errorf("failed to read plugin schema from '%s' (%w). Deployer close error: (%s)",
+				pluginSource, err, deployerErr.Error())
+		}
 	}
 	// Tell the server that the client is done
 	if err := transport.Close(); err != nil {