Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Version Regular Expression Update #115

Closed
wants to merge 24 commits into from
Closed

CI Version Regular Expression Update #115

wants to merge 24 commits into from

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Oct 25, 2023 •
edited
Loading

Changes introduced with this PR

Update the version format regular expression to include potential pre-release and/or build identifiers as in the semantic versioning 2.0.0 specification.

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

<version core> ::= <major> "." <minor> "." <patch>

By contributing to this repository, I agree to the contribution guidelines.

jaredoconnell and others added 24 commits August 4, 2023 10:16
@jaredoconnell
Added workflow pre-validation
c6fc1cd 
Also improved debug messages
@jaredoconnell
Updated go mod/sum
5e5659a
@jaredoconnell
Progress towards debugging deadlock detection
25fa40e 
Mostly this is test cases, and some mild refactoring that should have a similar result
@jaredoconnell
Use image that supports ARM64
8188317
@jaredoconnell
Ensure that run finishes before closing the step
e715add 
This ensures that the goroutines are done when the engine exits. This fixes a test case, and will be important when retrying is added to the deadlock check
@jaredoconnell
Added deadlock check retries
ac0ef7e 
This is a workaround for the situation where all of the steps are processing at the same time, all waiting for input
@jaredoconnell
Update test cases to take less time
c5696ec 
Also improved error logic
@jaredoconnell
Update dependencies
4c72b39 
Required for prior commits to work
@jaredoconnell
Update go SDK to dev branch
54503ae 
This adds the done message to the SDK
@jaredoconnell
Updated test deployer to dev branch
9ad0570
@jaredoconnell
Updated deployers, and added python deployer to run-plugin
1770f19
@jaredoconnell
Label loggers
2fe30be
@jaredoconnell
Update to use ATP v3
cb57e6c 
This means new error handling, so multiple errors can be reported
@jaredoconnell
Update SDK in go mod, and add force stop to step interface
30b9c23 
Force stop is good for when you do not need to wait for the ATP client, or something equivalant, to finish. Waiting for the ATP to finish means waiting for the steps to finish entirely.
@jaredoconnell
Merge branch 'main' into atp-v2
9088d54
@jaredoconnell
Cleanup
4f87b19
@jaredoconnell
Fix tests
e1768b5
@jaredoconnell
Update SDK and test deployer
f165777
@jaredoconnell
Reduce redundancy in Plugin Provider
d8c64bc
@jaredoconnell
Refactoring to fix linting errors
ce8c752 
I reduced the amount of code in one function, and reduced redundancy of unlocking
@jaredoconnell
Fix linting errors
ec46f7b 
These ones were only shown on CI, not locally
@dustinblack
bump internal dependencies
58e5bf0
@dustinblack
update all internal dependencies
3fe61d5
@mfleader
check for build
8953461
@mfleader mfleader added the bug Something isn't working label Oct 25, 2023
@mfleader mfleader self-assigned this Oct 25, 2023
@mfleader mfleader closed this Oct 25, 2023
@mfleader mfleader deleted the ci-version-regex branch January 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell Awaiting requested review from jaredoconnell

Assignees

@mfleader mfleader

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfleader @jaredoconnell @dustinblack