Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Update CI Regular Expression #116

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix and Update CI Regular Expression #116

merged 1 commit into from
Oct 25, 2023

Conversation

mfleader
Copy link
Member

Changes introduced with this PR

Update the version format regular expression to include potential pre-release and/or build identifiers as in the semantic versioning 2.0.0 specification.

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

<version core> ::= <major> "." <minor> "." <patch>

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader added the bug Something isn't working label Oct 25, 2023
@mfleader mfleader self-assigned this Oct 25, 2023
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more strict than we've been doing, but that's okay. Approved.

@mfleader mfleader merged commit 1431d1b into main Oct 25, 2023
5 checks passed
@mfleader mfleader deleted the version-regex branch October 25, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants