Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait For validation #133

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Wait For validation #133

merged 5 commits into from
Dec 6, 2023

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Dec 4, 2023

Changes introduced with this PR

Validate wait_for value is an expression with an output.

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader self-assigned this Dec 4, 2023
jaredoconnell
jaredoconnell reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to add some comments. It took a while for us to dig into this code, so I think it's worth the effort to add some comments explaining buildOutputProperties and addOutputProperties.

@mfleader mfleader merged commit ffc9891 into main Dec 6, 2023
5 checks passed
@mfleader mfleader deleted the waitfor-validation branch December 6, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees

@mfleader mfleader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfleader @jaredoconnell