Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default test #134

Merged
merged 22 commits into from
Feb 29, 2024
Merged

Default test #134

merged 22 commits into from
Feb 29, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Dec 6, 2023 •
edited
Loading

Changes introduced with this PR

  • Unserialize inputs to get workflow defaults, then reserialize inputs for execution.
  • Add test for workflow default input when it is defined and input is empty.
  • Add test for double serialization detection in a workflow with defaults defined for a property.

By contributing to this repository, I agree to the contribution guidelines.

jaredoconnell
jaredoconnell reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's not merge this until Dustin's workflow is tested.

@dustinblack
Copy link
Member

Functional tests are good in my workflows.

dustinblack
dustinblack approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@dustinblack dustinblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredoconnell
Copy link
Contributor

We're going to wait to merge this until an issue with re-serializing oneof is fixed.

webbnh
webbnh approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the "other half of the test" is being run and is passing.

engine_test.go Outdated Show resolved Hide resolved
@jaredoconnell
Copy link
Contributor

We should likely wait unto the changes to the Go SDK are incorporated. And potentially also wait for the double-serialization test to be added.

webbnh
webbnh reviewed Feb 17, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks OK. 😉

@mfleader mfleader marked this pull request as draft February 20, 2024 16:52
webbnh
webbnh reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks OK. 🙃 I just have a comment and a confirmation question.

engine_test.go Show resolved Hide resolved
internal/step/registry/registry.go Show resolved Hide resolved
@mfleader mfleader marked this pull request as ready for review February 28, 2024 21:31
webbnh

This comment was marked as resolved.

Sign in to view

@mfleader mfleader requested a review from webbnh February 29, 2024 21:44
webbnh
webbnh approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a suggestion.

workflow/workflow_test.go Outdated Show resolved Hide resolved
webbnh
webbnh approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks yummy! 😋

@mfleader mfleader merged commit 95baaa5 into main Feb 29, 2024
5 checks passed
@mfleader mfleader deleted the default-test branch February 29, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@dustinblack dustinblack dustinblack approved these changes

@webbnh webbnh webbnh approved these changes

@jaredoconnell jaredoconnell Awaiting requested review from jaredoconnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfleader @dustinblack @jaredoconnell @webbnh @dbutenhof