Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependency system: Part 1 #193

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Use dependency system: Part 1 #193

merged 8 commits into from
Jul 1, 2024

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This is the first PR related to using the dependency system. This PR simply replaces the old behavior that used getting nodes without inbound connections, with the simplest version of the dependency system.

The next PR will be much larger and adds unresolvable resolutions. I have 800+ lines on my local system for it. It exposes many issues.


By contributing to this repository, I agree to the contribution guidelines.

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I just have one question about a spot where we don't call PopReadyNodes(), and the rest is suggestions and nits.

workflow/workflow.go Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
workflow/workflow.go Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
workflow/workflow.go Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
Copy link
Member

@mfleader mfleader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also curious about @webbnh's conversations that I marked with emojis.

@mfleader mfleader self-requested a review June 26, 2024 15:47
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo our PopReadyNodes() discussion.

workflow/workflow.go Show resolved Hide resolved
workflow/workflow.go Show resolved Hide resolved
workflow/workflow.go Outdated Show resolved Hide resolved
@jaredoconnell jaredoconnell merged commit b16b8ff into main Jul 1, 2024
5 checks passed
@jaredoconnell jaredoconnell deleted the use-dependency-system branch July 1, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants