-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dependency system: Part 1 #193
Conversation
Won't work without the workspace due to the changes not being released yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I just have one question about a spot where we don't call PopReadyNodes()
, and the rest is suggestions and nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also curious about @webbnh's conversations that I marked with emojis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo our PopReadyNodes()
discussion.
Changes introduced with this PR
This is the first PR related to using the dependency system. This PR simply replaces the old behavior that used getting nodes without inbound connections, with the simplest version of the dependency system.
The next PR will be much larger and adds unresolvable resolutions. I have 800+ lines on my local system for it. It exposes many issues.
By contributing to this repository, I agree to the contribution guidelines.