Use dependency System: Part 2; Marking as unresolvable #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is missing dependency updates
This is especially important with this branch because it exposed a lot of problems
|
I need to test if this works with subworkflow/foreach. If it doesn't, I don't think that has to block these changes, but it should be an immediate follow-up PR. |
dbutenhof
reviewed
Jul 10, 2024
mfleader
requested changes
Jul 10, 2024
dbutenhof
reviewed
Jul 10, 2024
dbutenhof
approved these changes
Jul 10, 2024
This ensures that the waitgroup properly waits for all steps. There used to be a race condition that caused it to call Wait before Add()
dbutenhof
approved these changes
Jul 11, 2024
Fixed improper locking, paths that could lead to double-resolution, and more.
dbutenhof
reviewed
Jul 26, 2024
|
Are we missing a commit here? I thought you were making a few minor changes after the meeting, and I don't see anything. |
mfleader
approved these changes
Jul 29, 2024
Yes. I will push the commit. |
dbutenhof
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
The way this works is by marking all outputs that failed as unresolvable.
A callback called
OnStepStageFailurewas created to allow the providers to self-report failure of specific stages within their lifecycle for a step. The callback is required because the DAG itself doesn't know everything.Once all outputs are marked unresolvable, the entire workflow exits at that time. It will not keep things running.
The old way of determining failure is still implemented, but any activation of it is considered a bug, either due to a false activation, or due to a missing mark of unresolvability.
With the bugs fixed in the updated dependencies, the tests are very resilient based on my testing. This will need testing with real-world workflows.
By contributing to this repository, I agree to the contribution guidelines.