Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random numbering to the loadfile test #203

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

jaredoconnell
Copy link
Contributor

@jaredoconnell jaredoconnell commented Aug 21, 2024

Changes introduced with this PR

I always needed to comment out this test case when running all tests due to the issues running this test with count > 1.
This uses the standard library temp file randomization. Tested with 20,000 count.


By contributing to this repository, I agree to the contribution guidelines.

loadfile/loadfile_test.go Outdated Show resolved Hide resolved
loadfile/loadfile_test.go Outdated Show resolved Hide resolved
loadfile/loadfile_test.go Outdated Show resolved Hide resolved
loadfile/loadfile_test.go Outdated Show resolved Hide resolved
loadfile/loadfile_test.go Outdated Show resolved Hide resolved
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wonder if we're sure these temp dirs are being cleaned up, and I was having trouble finding documentation on that part of the test framework ... but I'll blithely assume they are unless told otherwise and pretend I didn't even think about it. 😁

loadfile/loadfile_test.go Outdated Show resolved Hide resolved
@mfleader mfleader self-requested a review August 22, 2024 18:20
@jaredoconnell jaredoconnell merged commit aa02243 into main Aug 22, 2024
5 checks passed
@jaredoconnell jaredoconnell deleted the loadfile-test-collision-fix branch August 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants