Oneof Outputs for Graceful Handling of Disabled Steps #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only waiting for the dependency on the DAG to be updatd
dbutenhof
reviewed
Sep 10, 2024
There was a problem hiding this comment.
I'll read through this again for more depth, but I've been working on extracting Crucible data all day and I want to submit the comments I've managed to generate today before I forget.
I haven't spotted any major problems, but I think some sections could use a bit of cleanup.
dbutenhof
approved these changes
Sep 12, 2024
mfleader
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This Pull Request adds a way to output a Oneof type. This allows OR logic for outputs and step inputs, allowing you allow multiple cases without creating multiple outputs or steps.
For examples of usage, see
workflow_test.goBy contributing to this repository, I agree to the contribution guidelines.