Added optional expression tags #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfleader
requested changes
Sep 19, 2024
|
Are there any edge cases that you know of that are intentionally left uncovered by these tests? |
Theoretically a soft-optional dependency could be included in more test cases, including alongside ORs, but that feature is, by design, not as reliable, and I didn't want to make the tests too fragile. |
dbutenhof
approved these changes
Sep 19, 2024
dbutenhof
approved these changes
Sep 19, 2024
mfleader
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This PR adds two more ways of specifying inferred inputs/outputs:
!wait-optional- Creates a completion dependency that still resolves if the referenced expression fails, but it will wait until either it resolves or it is marked unresolvable. This is the one intended for most use cases. For example, if you don't care if a step succeeds or crashes,!wait-optionalis the best one for that use case. But if you want the output to only resolve when the step is disabled or succeeds, but not if it crashes, you must use!ordisabled.!soft-optional- Creates an optional dependency that does not effect resolution of the object. There are no order guarantees, so this field is only intended for things that really do not matter strongly for the output.These expressions may only be used as fields properties within an object. The fields will be marked as optional.
By contributing to this repository, I agree to the contribution guidelines.