-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Solana API #210
base: dev
Are you sure you want to change the base?
New Solana API #210
Conversation
✅ Deploy Preview for dev-authsdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authsdk-ref-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/solana.ts
Outdated
case 'signMessage': { | ||
return bs58.decode(<string>response) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmjee response of this will be of the format
type SignatureRes = {
publicKey: BN // can use new solanaWeb3.PublicKey(address),
signature: Base58Decoded
}
src/solana.ts
Outdated
return (await this.p.request({ | ||
method: 'signMessage', | ||
params: { | ||
message: data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmjee message will be TextEncoded format
{
message: new TextEncoder().encode(message)
}
And then auth SDK will need to bs58 encode it
* intial code for esm build * Little adjustment --------- Co-authored-by: mmjee <[email protected]>
93855c9
to
b265f10
Compare
PR
Describe your changes
See ticket. WIP implementation of a new API for Solana consumers to maintain parity with well-known wallets. Will attempt to make it behave identically to others.
Issue ticket number and link
Checklist before requesting a review