Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #AR-8376 sdk ref theme update #230

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

shaloo
Copy link
Contributor

@shaloo shaloo commented Aug 12, 2024

PR

Describe your changes

Auth SDK Reference Layout Theme update

  • Also fixed internal references - hidden now.

Before:

Screenshot 2024-08-12 at 7 10 35 PM

After:
Screenshot 2024-08-12 at 7 11 07 PM

Issue ticket number and link

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

@shaloo shaloo added the documentation Improvements or additions to documentation label Aug 12, 2024
@shaloo shaloo requested a review from makylfang August 12, 2024 13:39
@shaloo shaloo self-assigned this Aug 12, 2024
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for authsdk-ref-guide ready!

Name Link
🔨 Latest commit a39319f
🔍 Latest deploy log https://app.netlify.com/sites/authsdk-ref-guide/deploys/66bad48b9fd83d00085ccf63
😎 Deploy Preview https://deploy-preview-230--authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaloo shaloo force-pushed the shaloo/AR-8376-sdk-ref-theme-update branch from ef686c7 to 3875e15 Compare August 12, 2024 14:45
@shaloo
Copy link
Contributor Author

shaloo commented Aug 13, 2024

@makylfang can u pls approve this? Need to publish it here: https://authsdk-ref-guide.netlify.app/ via main branch. Thx

@shaloo shaloo requested a review from mmjee August 13, 2024 03:29
@makylfang makylfang changed the base branch from main to dev August 13, 2024 06:17
@shaloo shaloo merged commit 4107309 into dev Aug 16, 2024
10 of 11 checks passed
@shaloo shaloo deleted the shaloo/AR-8376-sdk-ref-theme-update branch August 16, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants