[refactor] add set_cpumask apis, seperate CurrentRunQueueRef, add put_task_with_state #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equation314
reviewed
Oct 13, 2024
equation314
reviewed
Oct 13, 2024
equation314
reviewed
Oct 14, 2024
equation314
reviewed
Oct 16, 2024
equation314
reviewed
Oct 16, 2024
equation314
reviewed
Oct 17, 2024
modules/axtask/src/run_queue.rs
Outdated
| if !prev.is_idle() { | ||
| self.scheduler.lock().put_prev_task(prev.clone(), preempt); | ||
| } | ||
| /// Common reschedule subroutine, |
There was a problem hiding this comment.
maybe, it's not common routine now, ( I renamed it as subroutine if you noticed
modules/axtask/src/run_queue.rs
Outdated
| @@ -53,11 +53,11 @@ const ARRAY_REPEAT_VALUE: MaybeUninit<&'static mut AxRunQueue> = MaybeUninit::un | |||
| /// | |||
| /// ## Returns | |||
| /// | |||
| /// A static reference to the current run queue. | |||
| /// [`CurRunQueueRef`]: a static reference to the current `AxRunQueue`. | |||
There was a problem hiding this comment.
It is conflicted with existing hyperlink syntax of rustdoc.
There was a problem hiding this comment.
ok, I've fixed them as CurRunQueueRef
modules/axtask/src/run_queue.rs
Outdated
| /// Note: | ||
| /// `CurRunQueueRef` is used to get a reference to the run queue on current CPU, | ||
| /// in which scheduling operations can be performed. | ||
| pub(crate) struct CurRunQueueRef<'a, G: BaseGuard> { |
There was a problem hiding this comment.
Use full name: CurrentRunQueueRef
hky1999
changed the title
equation314
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.