dup the klass config on retrieval so it does not clear between calls

arches · Jan 6, 2017 · 6d911f4 · 6d911f4
1 parent 50d1dfa
commit 6d911f4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/table_print/config.rb b/lib/table_print/config.rb
@@ -25,7 +25,14 @@ def self.set(klass, val)
     end
 
     def self.for(klass)
-      @@klasses.fetch(klass) {}
+      config = @@klasses.fetch(klass) {}
+      if config.is_a?(Array)
+        config.map { |c| c.is_a?(Hash) ? c.dup : c }
+      elsif config.is_a?(Hash)
+        config.dup
+      else
+        config    
+      end
     end
 
     def self.clear(klass)

diff --git a/spec/config_spec.rb b/spec/config_spec.rb
@@ -37,6 +37,12 @@
         TablePrint::Config.set(Sandbox::Blog, [:title, :author])
         TablePrint::Config.for(Sandbox::Blog).should == [:title, :author]
       end
+
+      it "makes a copy on retrieval" do |variable|
+        TablePrint::Config.set(Sandbox::Blog, [:title, :author])
+        TablePrint::Config.for(Sandbox::Blog).clear
+        TablePrint::Config.for(Sandbox::Blog).should == [:title, :author]
+      end
     end
 
     describe "clearing" do