Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimenting with declarative shadow dom #20

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Experimenting with declarative shadow dom #20

wants to merge 7 commits into from

Conversation

t-kelly
Copy link
Member

@t-kelly t-kelly commented May 29, 2024 •
edited
Loading

Preview Link (Password: devkit)

Testing what things look like if we replace bundling stylesheets with fully encapsulating each component.

Remaining TODO:

  • product-media-gallery image widths aren't lining up
  • PDP blocks aren't responding to changes in variant
  • Will features powered by styles + scripts in {{ content_for_header }}, like dynamic checkout buttons, still work through shadow DOM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberthe chrisberthe Awaiting requested review from chrisberthe

@montalvomiguelo montalvomiguelo Awaiting requested review from montalvomiguelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-kelly