-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad definition of NotFoundError for TS #32
Open
igorvolnyi
wants to merge
9
commits into
archfirst:master
Choose a base branch
from
igorvolnyi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7c357d0 - Browse repository at this point
Copy the full SHA 7c357d0View commit details
Commits on Nov 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d898a8b - Browse repository at this point
Copy the full SHA d898a8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cbc843 - Browse repository at this point
Copy the full SHA 2cbc843View commit details -
Rename project from join-js to joinjs
Looks like original author abandoned the project and doesn't want to fix bugs, though I made a pull request. So for now I'll try to publish this version on npm.
Configuration menu - View commit details
-
Copy full SHA for 317a349 - Browse repository at this point
Copy the full SHA 317a349View commit details -
Merge branch 'master' of https://github.com/igorvolnyi/joinjs
Add .github/workflows/npm-publish.yml
Configuration menu - View commit details
-
Copy full SHA for a224208 - Browse repository at this point
Copy the full SHA a224208View commit details -
Configuration menu - View commit details
-
Copy full SHA for f882e83 - Browse repository at this point
Copy the full SHA f882e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d902e4 - Browse repository at this point
Copy the full SHA 8d902e4View commit details -
Because had to build before publishing to npm
Configuration menu - View commit details
-
Copy full SHA for 1c7e6cf - Browse repository at this point
Copy the full SHA 1c7e6cfView commit details -
Forgot to rename module definition in index.d.ts
So bump version again, dammit!
Configuration menu - View commit details
-
Copy full SHA for e33a0ee - Browse repository at this point
Copy the full SHA e33a0eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.