-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP Datacenter #187
Merged
Merged
GCP Datacenter #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gcp-kubernetes
…ing wrong protocol
…gcp-kubernetes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 85.57% 79.66% -5.91%
==========================================
Files 61 60 -1
Lines 20257 11375 -8882
Branches 301 437 +136
==========================================
- Hits 17334 9062 -8272
+ Misses 2904 2289 -615
- Partials 19 24 +5
|
davidthor
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Ryan added some modules that aren't currently being used that are code from the original GCP Provider but only used for the serverless deployment (the
gce
prefixed folders) - I didn't test or change these but figured I would leave them in for now because they could be used in a GCP serverless datacenter.I also made a couple very small code changes in the
build module
andbuild datacenter
to support verbose logging. Also addeddeno task compile:linux
which is used to build the CLI to drop into the DO bucket https://cloud.digitalocean.com/spaces/arcctl-dcs which Github Actions are using