Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: The resource name for the HTTP Event AWS generates contains the lambda name twice #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MartinRamm
Copy link

During the deployment, AWS first creates the new resource and the deletes the old one. Therefore, this fix does not cause any sort of downtime. It should also be backwards compatible, unless someone relies on the HTTP event name schema while overriding the cloudformation template in the deploy.start hook.

This fixes architect/architect#1487

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

…he lambda name twice

During the deployment, AWS first creates the new resource and the deletes the old one.
Therefore, this fix does not cause any sort of downtime. It should also be backwards
compatible, unless someone relies on the HTTP event name schema while overriding the
cloudformation template in the `deploy.start` hook.

This fixes architect/architect#1487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deployment failure: Template format error: Resource name '...' length is greater than 255.
1 participant