Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the PlatformMethods generation from TransformExpectPlatform to RemapInjectables, where its used #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnAwesomGuy
Copy link

so that i dont have a completely useless architectury_inject_blah_common_hashhashblahblah thing in my jar

p.s.: i dont really know how i would test this, so please dont kill me if it doesnt work properly

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2024

CLA assistant check
All committers have signed the CLA.

@Edouard127
Copy link
Contributor

If you want to test it you can publish the artifacts to your local maven repository using gradle publishToMavenLocal and then in your arch project you put the artifact version (shown in the console) like this

allprojects {
    architectury {
        transformerVersion = "2.1.35"
    }
}

@Edouard127
Copy link
Contributor

Tests

All tests were made using Architectury Loom 1.7.412 using Java 17 on windows and linux

1.20.4 Fabric 0.15.11 ✅
1.20.4 Forge 49.1.4 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants