Skip to content

Added support for extra data of file entry #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for extra data of file entry #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f11b129
Added support for extra data of file entry
anthrax63 Feb 2, 2017
86e62b2
Fix old node version support
anthrax63 Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ ZipStream.prototype.entry = function(source, data, callback) {
entry.setUnixMode(data.mode);
}

if (data.extra) {
entry.setExtra(data.extra);
}

return ZipArchiveOutputStream.prototype.entry.call(this, entry, source, callback);
};

Expand Down
16 changes: 16 additions & 0 deletions test/pack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,22 @@ describe('pack', function() {
archive.finalize();
});

it('should support file extra', function(done) {
var archive = new Packer();
var extra = new Buffer('Extra data', 'UTF-8');

var testStream = new WriteHashStream('tmp/extra.zip');

testStream.on('close', function() {
done();
});

archive.pipe(testStream);

archive.entry(testBuffer, { name: 'buffer.txt', date: testDate, extra: extra});
archive.finalize();
});

it('should STORE files when compression level is zero', function(done) {
var archive = new Packer({
forceUTC: true,
Expand Down