tracker: add security splash page as index #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantiagoTorres
force-pushed
the
add-security-information-page
branch
2 times, most recently
from
ac3f741 to
3ce4591
Compare
jelly
reviewed
Jul 28, 2019
jelly
reviewed
Jul 28, 2019
jelly
reviewed
Jul 28, 2019
jelly
requested changes
Jul 28, 2019
|
Thanks for the review. I addressed your comments (I believe), @jelly |
jelly
previously approved these changes
Jul 30, 2019
More information on how to submit vulnerablities on arch linux components and infrastructure, as well as how to report issues with packages is necessary to ease the vulnerablity disclosure process. Signed-off-by: Santiago Torres <[email protected]>
SantiagoTorres
force-pushed
the
add-security-information-page
branch
from
11b218b to
0debf98
Compare
|
Just rebased. Cheers! |
The old behavior that followed a login attempt was to redirect to the index, which used to be the index (equivalent to index_vulnerable). With the new security splash page, this behavior breaks. While it is still up to discussion whether the after-login behavior should be to redirect to the security splash page instead of index_vulnerable, for now we still need to keep the existing behavior. Rewire the redirects on from tracker.index to tracker.index_vulnerable on the login views. Finally, update test_login to reflect this behavior. Signed-off-by: Santiago Torres <[email protected]>
test_index used to have a test that targeted the '/' url. Since index does not respond to that url anymore, the test should be removed. Instead, a simpler version of the same test is added on a new module called test_home. Signed-off-by: Santiago Torres <[email protected]>
SantiagoTorres
force-pushed
the
add-security-information-page
branch
from
0debf98 to
7345545
Compare
jelly
reviewed
Mar 9, 2021
|
Overal LGTM |
Foxboron
reviewed
May 10, 2021
Comment on lines
+25
to
+26
| <li><a href="https://www.archlinux.org/people/developers/#allan">Allan McRae</a> | ||
| <tt>6645 B0A8 C700 5E78 DB1D 7864 F99F FE0F EAE9 99BD</tt></li> |
There was a problem hiding this comment.
Should we remove Allan? @anthraxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information on how to submit vulnerablities on arch linux
components and infrastructure, as well as how to report issues with
packages is necessary to ease the vulnerablity disclosure process.
Some previous discussion happened here