Fix many typos #1692
Merged
Fix many typos #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this against |
|
@goggle any chance you could update the PR with latest master? |
Signed-off-by: Alexander Seiler <[email protected]>
|
@Torxed @svartkanin Here is an updated version of this PR. |
erickisos
reviewed
Sep 18, 2023
| @@ -119,7 +119,7 @@ def setup_selection_menu_options(self): | |||
| self._menu_options['parallel downloads'] = \ | |||
| Selector( | |||
| _('Parallel Downloads'), | |||
| lambda preset: add_number_of_parrallel_downloads(preset), | |||
| lambda preset: add_number_of_parallel_downloads(preset), | |||
There was a problem hiding this comment.
Can we pass the method reference instead of a lambda?
Suggested change
| lambda preset: add_number_of_parallel_downloads(preset), | |
| add_number_of_parallel_downloads, |
There was a problem hiding this comment.
Will the preset be preserved in the way we call the function at a later stage?
There was a problem hiding this comment.
we do it the same way with most other settings as well, I don't think it makes much difference
Torxed
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Corrects various typos that I've found in the repository. Please double-check that I haven't forgotten to adapt any method calls for the corrected method name definitions.
Tests and Checks