-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed hyperland to hyprland, fixed seatd via post_installation and added waybar-hyprland #1824
Conversation
Gonna make waybar auto config next
I can't test rn I'm on vacation and my connection is quite bad (68 days for arch iso)
@Sxmourai is the configuration actually needed to get hyprland working? Or is it a better default? Archinstall shouldn't configure anything beyond the minimum setup otherwise it's a rabbit hole with no return |
I agree with @svartkanin on this one - as is, it looks too opinionated. We try not to configure too much for the user other than the bare minimum for the desktop to be usable out of the box. If it's not usable without a bunch of custom profiles, etc. perhaps it is a candidate for removal and they can set it up w/ the generic xorg profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking this over, I belive all of the sample configuration would need to be removed before this profile is suitable for archinstall.
@svartkanin Yes it is a better default... But the automatic support for nvidia could be interesting |
-1 as is. While I appreciate that the configs will likely lead to a better/more optimal out of the box experience, as mentioned, changing defaults is a rabbit hole, users should configure their own system, and we don't really want to deviate from default configuration in the installer. I think the configurations should be dropped entirely unless the environment actually doesn't work at all without them due to the aforementioned reasons. |
@dylanmtaylor But if we make it configurable ? |
If we're making this configurable then so would the other profiles have to be. This is a personalised configuration, even if the majority of users are using it, it's still a configuration on top of the default out of the box one. |
I agree with @dylanmtaylor and @svartkanin here. If this project ever reaches Red Hat level of maintainers maybe we can reconsider it, otherwise this is best left up to the user with traditional tooling :) Appreciate the work tho! But I'll merge this when the above mentioned changes are implemented and then we can revisit the other things at a later time :) |
I think I've reverted the changes mentioned in the comments. But that should be a separate PR, otherwise this PR will do many things and while I allow it in some situations I would prefer if this PR was regarding hyprland only (and ideally just the renaming since that's what the title is hehe). But I kept the renaming, and then added a seat selector as both seatd and polit appears to be options for Hyprland. Note that I have never used hyprland tho and feedback on usage is welcome. |
@Torxed likely missing gpu accel, since it's a VM. Either enable it or pass Also confront stdout and stderr for more verbose logs. |
Yes sorry ! I coded this mostly in the car while going on holidays 😅 |
@svartkanin I think this is the one to merge, of all the Hyprland renames heh. |
The class name is still set to |
Removed |
kitty was probably there because the default terminal in hyprland is kitty, so in the autogenerated config there is only a bind to launch kitty, no other terminal. |
Ah, maybe we add it in then. As I assume it will be hard graphically to do anything cmd related otherwise? |
I agree with this. If the original developers are that opinionated on what tools are used, we need to provide a working out of the box installation. |
I opened a PR to add them, but need at least one approval in order to merge. |
I have a "welcome"/"initial setup" type of utility planned for hyprland, but it's, as I said, just planned. For now, I just made those binds a year ago resembling what I was using and it kinda stuck around. |
Ah you're the creator, just noticed. Thanks for the feedback here and cool to see everyone get involved :) hope the profile looks good. A setup would be handy I recon, but with any project.. there's always more urgent tasks hehe |
PR Description:
Renamed the "hyperland" profile to "hyprland".
Fix seatd (when I test hyprland seatd always fails on opening seat)
Install waybar-hyprland by default, (waybar-hyprland and not waybar for the workspaces)
Tests and Checks