Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _get_kernel_params() #2064

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

codefiles
Copy link
Contributor

The kernel parameters used in _add_systemd_bootloader() and _add_efistub_bootloader() should be identical.

@svartkanin
Copy link
Collaborator

Looking at the efistub and systemd implementations they do have some differences

  • zram
  • subvols
  • hsm

are we saying that those were originally missing from the efistub setup?

@codefiles
Copy link
Contributor Author

Yes, they should be identical and are not since those are missing. This is intended to fix that and keep the code from being duplicated.

@svartkanin
Copy link
Collaborator

svartkanin commented Sep 18, 2023

Gotcha, I see that grub also doesn't have them, are they missing there as well?

@codefiles
Copy link
Contributor Author

codefiles commented Sep 18, 2023

The only boot loader with a fleshed out list of kernel parameters is systemd-boot. I plan to investigate application of this function to the other boot loaders. It may require additional changes to work with GRUB since by default grub-mkconfig determines the root filesystem. Other kernel parameters may be omitted due to its configuration as well.

With that said, there is nothing left to do here. This pull request is concise and is ready for merge.

@svartkanin svartkanin merged commit 6ec2bd4 into archlinux:master Sep 18, 2023
6 checks passed
@codefiles codefiles deleted the kernel-params branch September 18, 2023 13:40
@codefiles codefiles mentioned this pull request Sep 18, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants