Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SUPPORTED file for locale options #2069

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

codefiles
Copy link
Contributor

Fixes #2041

@codefiles codefiles changed the title Use SUPPORTED file for locale options and validation Use SUPPORTED file for locale options Sep 19, 2023
@Torxed
Copy link
Member

Torxed commented Sep 19, 2023

Looks good, just add glibc to https://github.com/archlinux/archinstall/blob/master/PKGBUILD#L13 and I'll merge it to the upstream package.

@svartkanin svartkanin merged commit 33d084f into archlinux:master Sep 19, 2023
6 checks passed
@codefiles codefiles deleted the locale-supported branch September 19, 2023 22:16
@codefiles
Copy link
Contributor Author

codefiles commented Sep 23, 2023

Just a reminder that the PKGBUILD change has not been merged upstream. I also want to add that glibc should have already been in the dependency list of the PKGBUILD since locale-gen, which is from that package, is being used.

Torxed added a commit that referenced this pull request Sep 23, 2023
@Torxed
Copy link
Member

Torxed commented Sep 23, 2023

On it, thanks for the reminder :) Just got back from a trip, so will begin packaging (and updating upstream) soon.
And yea, there's a few missing direct deps in the PKGBUILD, I started making it more accurate by adding the direct commands we execute but haven't made the list perfect.
If we find any more, feel free to add them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locale language only en_US
3 participants