-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically remove relevant repo_depends entries for official packages #17
Automatically remove relevant repo_depends entries for official packages #17
Conversation
Oh, issuebot should reject orphan requests with packages that are in repo_depends of other packages, too. Too lazy to finish them today. |
Maybe mention maintainers in a comment whose |
Here is my original plan: when the orphan request is created, listing packages that are used by other packages, and when |
I don't think this is a good idea. When a maintainer orphans packages, they mean to stopping maintaining them. No maintainer should be forced to maintain packages. I think there are two ways:
When depending packages break, their maintainers are expected to fix them. Given the same eventual outcome, I prefer 2 for simplicity. We notify depending-package maintainers in the orphaning issue so they can keep up. |
If we go that way and archlinuxcn/repo#1574 is merged, CI tests will be red for some time and everyone pushes to the repo during that period will receive mails about build failures. That sounds not good to me, either. An extreme case is lib32-libmng. It is orphaned and then removed on May 20, 2019. After that date, lib32-qt4 is broken until lib32-libmng is re-added on Apr 10, 2020 [2].
Indeed that makes more sense. How about transfer maintainership automatically? For example, if A is orphaned, and B and C repo_depends on A, then maintainers of A will become union of maintainers of B and C. |
Ah yes.
Maybe create a vote for this to collect options? One option is to transfer, the other is to keep without maintainers. The former may make responsibility vague because of multiple non-cooperative maintainers. What issues may the latter have? If an orphaned package A caused B to fail, maintainers of B are expected to look into the issue and they may decide to take over A or drop B. |
I guess no. Nevertheless, it's still better to collect opinions from more package maintainers, so I created archlinuxcn/repo#1676. |
* Set changed when needed * Add type hints
* Mention repo_depends in commit messages * Use lilac2.lilacyaml.iter_pkgdir
This time I only tested the third case: lxqt-build-tools, libqtxdg-git (multiple packages) |
Tested with the following cases
A sample commit for the last test case can be found at https://github.com/yan12125/repo/commit/49ab72085b3a0c0c9827cff1889feefdb5d14708
Note that a new dependency python-ruamel-yaml is introduced in this pull request.