fix: keep empty value in renderLinkedContainer of DatePicker
#309
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ PR Preview Link: https://preview-309-arco-design-mobile.surge.sh |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
adaex
approved these changes
Dec 12, 2024
|
Just that I think LGTM, need @TinaPeach to double-check, to avoid any issues |
TinaPeach
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
DatePickercomponent in thepackages/arcodesigndirectory. The changes focus on handling empty values more gracefully in therenderLinkedContainerfunction.Key changes:
packages/arcodesign/components/date-picker/index.tsx: AddedisEmptyValueimport from@arco-design/mobile-utilsto check for empty values.packages/arcodesign/components/date-picker/index.tsx: UpdatedrenderLinkedContainerto handle cases whereprops.currentTsis empty by passingundefinedinstead ofcurrentTs.packages/arcodesign/components/date-picker/type.ts: Modified therenderLinkedContainerfunction signature to acceptcurrentTsasnumber | undefinedinstead of justnumber.