Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized linear regression #896

Merged
merged 34 commits into from
Apr 12, 2024
Merged

Generalized linear regression #896

merged 34 commits into from
Apr 12, 2024

Conversation

rosemm
Copy link
Contributor

@rosemm rosemm commented Feb 16, 2024

New module!

@drelliche drelliche mentioned this pull request Mar 25, 2024
48 tasks
@rosemm
Copy link
Contributor Author

rosemm commented Apr 1, 2024

Okay, @drelliche it's ready for you again! I implemented several (hopefully!) improvements:

  • Moved around some existing content to improve the pedagogical flow, as we discussed, especially breaking up the sepsis example so the problematic attempt with the plain linear model occurs early on, and the better attempt with the logistic regression is toward the end
  • Smoothed out the new transitions, added a little more scaffolding around, in particular, the plot of the bad linear model
  • Substantially reworked the "probability and odds" bit, which is now under the heading "talking about chance" -- lemme know what you think
  • Added a whole new quiz to try to more effectively hammer home the question of what is (and isn't) a continuous unbounded outcome, to better support learning objective "identify when a logistic regression model is appropriate"
  • Added a little more explanation of plain linear models at the very beginning. I'm happy to take that out again, though, if you think it's overkill given that OLS is listed as a prereq.

@drelliche
Copy link
Contributor

@rosemm This looks great! I'll go over it for all of the checks/typos, etc in the next few days.

rosemm and others added 2 commits April 8, 2024 14:16
Copy link
Contributor

@franzenr franzenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a few small suggestions, and a point or two of clarification :)

I've always wanted to know more about logistic regression in particular, but never gotten around to reading up on it -- this was such a wonderful intro!! 😃

@rosemm
Copy link
Contributor Author

rosemm commented Apr 11, 2024

Thanks for the great edits, @franzenr! I think it's ready for you again -- lemme know if you want further clarification or anything :)

Co-authored-by: Rose M. Hartman <[email protected]>
@franzenr
Copy link
Contributor

@rosemm I've got two replies for you to mull over, but that's it!

@rosemm
Copy link
Contributor Author

rosemm commented Apr 11, 2024

Thanks, @franzenr ! Back to you :) 🎾

@franzenr
Copy link
Contributor

one last(?) lob @rosemm 🎾

Copy link
Contributor

@franzenr franzenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Rose! This is an awesome addition to our module collection :)

@rosemm rosemm merged commit 91a786f into main Apr 12, 2024
2 checks passed
@rosemm rosemm deleted the generalized_linear_regression branch April 12, 2024 15:13
@rosemm rosemm mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants