Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update directory structure requirements #943

Merged
merged 8 commits into from
Sep 4, 2024
Merged

update directory structure requirements #943

merged 8 commits into from
Sep 4, 2024

Conversation

franzenr
Copy link
Contributor

data folder technically new to docs, but already in use.

Also, changed src to code because src is not being used by anyone yet (mostly notebooks is in use, but that isn't well named for non-notebook files), so it will require the same amount of edits to bring up to standards either way, and code is more self-explanatory for learners who might poke around in our repo on their own to try to find materials.

Made edits to the QA templates for now, though won't be long until we can deploy the action that looks for this, at which point we should be able to just remove that section from the manual QA process all together.

franzenr added 6 commits July 11, 2024 12:27
link destination was blank -- added link to take users to version 3.1.2 of docs.
suggest we use `code` instead of `src` for the subdirectory to contain scripts, notebooks, etc as this is a more self-explanatory name for learners who are new to this field if they're poking around in the repo trying to find things. (Not a single one of our modules currently follows this rule anyways, so it will be the same amount of work to bring into compliance either way).
update QA templates to include up-to-date directory structure standards.
upversion docs, add old version to previous versions list, remove older versions so only 3 most recent priors are shown.
@rosemm rosemm self-requested a review July 24, 2024 13:49
Copy link
Contributor

@rosemm rosemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a checklist issue template for updating modules to v5

@rosemm rosemm merged commit a4f7025 into main Sep 4, 2024
2 checks passed
@rosemm rosemm deleted the docs_update branch September 4, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants