removed useless lines #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/LSM6DS3.cpp
Outdated
| @@ -91,9 +91,6 @@ int LSM6DS3Class::begin() | |||
| // set gyroscope power mode to high performance and bandwidth to 16 MHz | |||
| writeRegister(LSM6DS3_CTRL7_G, 0x00); | |||
|
|
|||
| // Set the ODR config register to ODR/4 | |||
| writeRegister(LSM6DS3_CTRL8_XL, 0x09); | |||
There was a problem hiding this comment.
@Rocketct do we want to consider updating the incorrect comment and change the value to 0x01 to enable LOW_PASS_ON_6D.
|
|
|
|
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed useless lines due to legacy from Arduino_LSM6DSM
Checking the Figure 6. Accelerometer composite filter on the LSM6DS3's datasheet: , this line have only the effect of enable the LOW_PASS_ON_6D and setting to 1 a bit that should be set to 0 because reserved, i'll remove because added only for redundancy in the other library and here don't make sense to exist.
cc/ @sandeepmistry just checked the datasheet this lines are unnecessary
fix #7