Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use InputStreamReader for serial UTF8 decoder #10389

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use InputStreamReader for serial UTF8 decoder #10389

wants to merge 3 commits into from

Commits on Jun 19, 2020

  1. Use InputStreamReader for serial UTF8 decoder 

    The implementation is much more straightforward.

It should also solve a JDK incompatiblity:

  java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
  at processing.app.Serial.serialEvent(Serial.java:185)
  at jssc.SerialPort$LinuxEventThread.run(SerialPort.java:1299)

See arduino#8903
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2162966 View commit details
    Browse the repository at this point in the history

  2. Serial UTF-8 decoder now handles blocks of 16Kb at a time

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    618eef0 View commit details
    Browse the repository at this point in the history

  3. Added test for invalid UTF-8 sequences

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    782a35b View commit details
    Browse the repository at this point in the history