Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trimming: trim() return value should be used. #11710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomasleplus
Copy link

The trim() method returns a new trimmed string, it does not alter the current string (strings being immutable in Java).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

@thomasleplus thomasleplus mentioned this pull request Nov 30, 2021
7 tasks
@abimarank
Copy link

Good to see the improvement made here #11666 (comment)

@thomasleplus
Copy link
Author

Any chance this PR will be merged? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants