Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira 916 913 BLESubscribed, BLEUnsubscribed Event Handlers are not called #532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Apr 14, 2017

  1. Implement the subscribe changed event notify feature.

Changed files:
BLECallbacks.cpp - Add subscribe changed handler and disconnect process
BLECallbacks.h - Callback declaration
BLECharacteristicImp.cpp - Add the event changed handler
BLECharacteristicImp.h - Handler declaration

#531

@russmcinnis
Copy link
Contributor

russmcinnis commented Apr 14, 2017

@SidLeung @sgbihu The subscribe and unsubscribe events are now generated on the peripheral. When unsubscribing the central is calling if (!ledCharacteristic.unsubscribe()) {
This is returning false even though the peripheral is seeing the unsubscribe. I will file a jira.

@SidLeung
Copy link
Contributor

@sgbihu Please check into the case in Central mode.

https://jira.ndg.intel.com/browse/ATLEDGE-916

@SidLeung SidLeung added this to the Elnath milestone Apr 14, 2017
1. Implement the subscribe changed event notify feature.
2. Fix unsubscribe return wrong value

Changed files:
  BLECallbacks.cpp - Add subscribe changed handler
  BLECallbacks.h - Callback declaration
  BLECharacteristicImp.cpp - Add the event changed handler
  BLECharacteristicImp.h - Handler declaration
  gatt.c - Modify the callback parameter
  gatt.h - Modify the structure

Fix
@novashah novashah changed the title Jira 913 BLESubscribed, BLEUnsubscribed Event Handlers are not called Jira 916 BLESubscribed, BLEUnsubscribed Event Handlers are not called Apr 25, 2017
@novashah novashah changed the title Jira 916 BLESubscribed, BLEUnsubscribed Event Handlers are not called Jira 916 913 BLESubscribed, BLEUnsubscribed Event Handlers are not called Apr 25, 2017
@kitsunami kitsunami removed this from the Elnath milestone Aug 30, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants