-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace strcpy by memcpy on String::concat(const char*, uint32_t); #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many edge case can be caused by strcpy, cause length not is taked care.
Replace strpcy by strlcpy on String::concat which doesn't care of the length.
Memory usage change @ 675ef46
Click for full report table
Click for full report CSV
|
Checking if memcpy use less than strlcpy
bilaliscarioth
changed the title
Replace strcpy by strlcpy on Strin.::concat(const char&*, uint32_t);
Replace strcpy by memcpy on String::concat(const char&*, uint32_t);
Jan 16, 2025
Memory usage change @ a4fdb6c
Click for full report table
Click for full report CSV
|
bilaliscarioth
changed the title
Replace strcpy by memcpy on String::concat(const char&*, uint32_t);
Replace strcpy by memcpy on String::concat(const char*, uint32_t);
Jan 17, 2025
Duplicated of #530... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR come from with the issues #590 , where I explain in details why strcpy is not safe.