Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added weak attribute to UART handlers #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anklimov
Copy link

added weak attribute to UART handlers to allow custom handlers override default UART routine
That is vital changes to implement DMX512 protocol over UART (for example) without manual changes of CORE libraries

added __weak__ attribute to UART handlers to allow custom handlers override default UART routine
That is vital changes to implement DMX512 protocol over UART (for example) without manual changes of CORE libraries
@anklimov
Copy link
Author

anklimov commented Nov 3, 2019

Hi! is some progress with PR review? That is a real problem now to ask everybody who compiling every project with low-level UART access to fix Arduino libs manually.

@gicking
Copy link

gicking commented Nov 6, 2019

hi anklimov,
I am having a similar problem for implementing an efficient LIN slave. Would be great if the team merged this (for all Serials)!
Georg

@anklimov
Copy link
Author

Is somebody still alive here? What reason do not accept PR? That is really difficult for users to modify core libraries every time then needed to re-compile project

@gicking
Copy link

gicking commented May 16, 2020

overwriting the UART ISRs seems to be a common wish as a similar proposal was already made in 2017 (see #1, and recently by me (see #95. And at least for the latter I have given up and implemented a LIN master handler differently. What a shame!

@anklimov
Copy link
Author

Hi @gicking
It looks you're right - the DUE project is discarded
I will appreciated if you share with everybody another option to override default USART handler (i didn't find another option but correct core source again and again to compile my code on DUE)

@gicking
Copy link

gicking commented May 24, 2020

hi anklimov,
actually I am hoping that the Due team is just overwhelmed with other tasks - after all the ARM-based Arduinos are still young, compared to the AVR 8-bitters... Anyway, the effect is the same: pull requests are ignored for a long time at least.

Regarding your question: as discussed in my pull-request #95, the elegant solution would to separate the UART-ISRs such that they can be overwritten by a library to support e.g. attaching user functions via NeoHWSerial. But that would require support by the Due team again... Alternatively, pull request #95 implements this functionality, namely attach an optional user routine to the UART Rx-ISR. Is that what you're looking for?

@odurc
Copy link

odurc commented Dec 5, 2020

overwriting the UART ISRs seems to be a common wish as a similar proposal was already made in 2017 (see #1, and recently by me (see #95. And at least for the latter I have given up and implemented a LIN master handler differently. What a shame!

Actually, the MR was open back in 2015, see arduino/Arduino#3023. They really should seriously consider adding more maintainers to this project.

@gicking
Copy link

gicking commented Dec 28, 2020

I give up. There is simply no point in contributing to Due core libraries if there is no response within >1 year - or in your example even 5 years! This way the community cannot be kept alive.
CU in another project. Over and out...

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@gicking
Copy link

gicking commented Apr 10, 2021

seriously? It takes 16 months to automatically send a legal form...???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants