-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added weak attribute to UART handlers #92
base: master
Are you sure you want to change the base?
Conversation
added __weak__ attribute to UART handlers to allow custom handlers override default UART routine That is vital changes to implement DMX512 protocol over UART (for example) without manual changes of CORE libraries
Hi! is some progress with PR review? That is a real problem now to ask everybody who compiling every project with low-level UART access to fix Arduino libs manually. |
hi anklimov, |
Is somebody still alive here? What reason do not accept PR? That is really difficult for users to modify core libraries every time then needed to re-compile project |
Hi @gicking |
hi anklimov, Regarding your question: as discussed in my pull-request #95, the elegant solution would to separate the UART-ISRs such that they can be overwritten by a library to support e.g. attaching user functions via NeoHWSerial. But that would require support by the Due team again... Alternatively, pull request #95 implements this functionality, namely attach an optional user routine to the UART Rx-ISR. Is that what you're looking for? |
Actually, the MR was open back in 2015, see arduino/Arduino#3023. They really should seriously consider adding more maintainers to this project. |
I give up. There is simply no point in contributing to Due core libraries if there is no response within >1 year - or in your example even 5 years! This way the community cannot be kept alive. |
seriously? It takes 16 months to automatically send a legal form...??? |
added weak attribute to UART handlers to allow custom handlers override default UART routine
That is vital changes to implement DMX512 protocol over UART (for example) without manual changes of CORE libraries