Skip to content

Commit

Permalink
apply CR suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
alessio-perugini committed Sep 11, 2023
1 parent 227dbd1 commit a38853b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion legacy/builder/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func containerBuildOptions(ctx *types.Context) types.BareCommand {
func warnAboutArchIncompatibleLibraries(ctx *types.Context) types.BareCommand {
return types.BareCommand(func(ctx *types.Context) error {
overrides, _ := ctx.BuildProperties.GetOk("architecture.override_check")
_ = WarnAboutArchIncompatibleLibraries(
WarnAboutArchIncompatibleLibraries(
ctx.TargetPlatform,
overrides,
ctx.SketchLibrariesDetector.ImportedLibraries(),
Expand Down
4 changes: 1 addition & 3 deletions legacy/builder/warn_about_arch_incompatible_libraries.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func WarnAboutArchIncompatibleLibraries(
overrides string,
importedLibraries libraries.List,
printInfoFn func(string),
) error {
) {
archs := []string{targetPlatform.Platform.Architecture}
if overrides != "" {
archs = append(archs, strings.Split(overrides, ",")...)
Expand All @@ -42,6 +42,4 @@ func WarnAboutArchIncompatibleLibraries(
strings.Join(archs, ", ")))
}
}

return nil
}

0 comments on commit a38853b

Please sign in to comment.