Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .cxx and .cc extension in compile #2273

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 22, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Allows compilation to build also .cxx and .cc files.

In theory, the platforms should provide a recipe for compiling cxx and cc specifically, but this implementation reuses the recipe for .cpp as a fallback if the specific recipes are missing (that is the situation for basically all the platforms in the existence, and it is unlikely to change in the future).

What is the current behavior?

.cxx and .cc files are ignored.

What is the new behavior?

.cxx and .cc files are compiled.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #1149

@cmaglie cmaglie added type: enhancement Proposed improvement topic: build-process Related to the sketch build process labels Aug 22, 2023
@cmaglie cmaglie added this to the Arduino CLI 0.35.0 milestone Aug 22, 2023
@cmaglie cmaglie self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (086b77a) 62.98% compared to head (c4d27be) 62.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2273   +/-   ##
=======================================
  Coverage   62.98%   62.99%           
=======================================
  Files         221      221           
  Lines       19746    19749    +3     
=======================================
+ Hits        12438    12441    +3     
  Misses       6206     6206           
  Partials     1102     1102           
Flag Coverage Δ
unit 62.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/builder_utils/utils.go 69.94% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 5314a7c into arduino:master Aug 23, 2023
91 checks passed
@cmaglie cmaglie deleted the allow_cxx_and_cc branch August 23, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build-process Related to the sketch build process type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add .cc and .cxx to OTHER_ALLOWED_EXTENSIONS
3 participants